[GEM Development] problems with EMMA

Liam Proven lproven at cix.co.uk
Wed Jul 20 16:23:34 PDT 2005


Shane M. Coughlan wrote:

> I am using a WindowsXP machine, and below is a copy of my GEM.BAT

You seem to have two different labels at 2 different points in the 
program that are called :1. That's not a good idea and could well cause 
problems. Why use "1" anyway? Why not a descriptive name as you already 
use elsewhere?

Also, the double-check and double-jump you consistently do is 
unnecessary. Both jump if a file exists and jump if it doesn't? The one 
logically implies the other; you don't need both. If the file doesn't 
exist, jump past the code for handling it, otherwise just let it run - 
let the thread of execution flow through undisturbed.

You could have posted the code right here on the list, where there are a 
whole bunch of us who would have given it a read-through for you and 
commented on it. That's what open source is all about. I may not have 
time to download & try a new release of GEM - indeed, most of the time, 
I use Linux and MacOS X, where it cannot and will not run - but I can 
always read a batch file and comment upon it.

-- 
Liam Proven
Home: http://welcome.to/liamsweb * Blog: http://lproven.livejournal.com
AOL, Yahoo UK: liamproven * ICQ: 73187508 * MSN: lproven at hotmail.com



More information about the gem-dev mailing list